This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Don't spew stacktrace on join when already member #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarin
pushed a commit
to binarin/rabbitmq-server
that referenced
this pull request
Jun 30, 2016
Because `{ok, _}` should mean OK, and `{error, _}` should be a real error.
With the addition of
rabbitmq/rabbitmq-common#115
`rabbitmqctl join_cluster` will become consistent.
|
I'd use "a member of this cluster" instead of "Properly clustered." Otherwise 👍. |
Example of stacktrace - rabbitmq/rabbitmq-server#709
binarin
force-pushed
the
rabbitmq-server-fix-join-cluster-when-already-member
branch
from
5a4ec30 to
03365fc
Compare
|
Done. |
|
Thank you. This will go into |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of stacktrace - rabbitmq/rabbitmq-server#709