Report join_cluster errors more thoroughly #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `{ok, _}` should mean OK, and `{error, _}` should be a real error.
With the addition of
rabbitmq/rabbitmq-common#115
`rabbitmqctl join_cluster` will become consistent.
binarin
pushed a commit
to binarin/rabbitmq-autocluster
that referenced
this pull request
Jul 1, 2016
Joining cluster may fail, so we need to handle failure according to `autocluster_failure` setting. Before rabbitmq/rabbitmq-server#868 even `{ok, already_member}` should be treated as an error, but I'm not so sure about this.
binarin
pushed a commit
to binarin/rabbitmq-server
that referenced
this pull request
Jul 29, 2016
Forgot to update specs in rabbitmq#868
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
{ok, _}should mean OK, and{error, _}should be a real error.mnesia_lib:all_nodes()is used bymnesia:info()even when mnesia is not running, so I think it's an appropriate function to call.With the addition of
rabbitmq/rabbitmq-common#115
rabbitmqctl join_clusterwill become idempotent, fixing #709.