Public API cleanup, round 3

[bording]

Proposed Changes

Here is what I'm expecting to be the final public API cleanup PR for the 6.x release. This internalizes the ConsumerWorkService class.

After looking at it a bit, it turned out to not be as involved as I was initially thinking it would be.

As mentioned before, I don't think is the final thing to do to clean up the public API surface. We should take a hard look the RabbitMQ.Client namespace, where most of the public types live now.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• All tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in related repositories

[lukebakken]

As mentioned before, I don't think is the final thing to do to clean up the public API surface. We should take a hard look the RabbitMQ.Client namespace, where most of the public types live now

I get the feeling like you'd like to see this for 6.0, correct?

[bording]

I get the feeling like you'd like to see this for 6.0, correct?

Ideally, yes, but I'm not sure it's something I can take on by myself in the timeframe you're talking about for 6.0.