Skip to content

Public API cleanup, round 3 #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Public API cleanup, round 3 #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions projects/client/RabbitMQ.Client/src/client/api/IConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,5 @@ public interface IConnection : INetworkConnection, IDisposable
/// Handle incoming Connection.Unblocked methods.
/// </summary>
void HandleConnectionUnblocked();

ConsumerWorkService ConsumerWorkService { get; }
}
}
2 changes: 1 addition & 1 deletion projects/client/RabbitMQ.Client/src/client/impl/ConsumerWorkService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace RabbitMQ.Client.Impl
{
public class ConsumerWorkService
class ConsumerWorkService
{
private readonly ConcurrentDictionary<IModel, WorkPool> _workPools = new ConcurrentDictionary<IModel, WorkPool>();

Expand Down
3 changes: 2 additions & 1 deletion projects/client/RabbitMQ.Client/src/client/impl/ISession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@

using System;
using System.Collections.Generic;
using RabbitMQ.Client.Framing.Impl;

namespace RabbitMQ.Client.Impl
{
Expand All @@ -63,7 +64,7 @@ interface ISession
/// <summary>
/// Gets the connection.
/// </summary>
IConnection Connection { get; }
Connection Connection { get; }

/// <summary>
/// Gets a value indicating whether this session is open.
Expand Down
5 changes: 0 additions & 5 deletions projects/client/RabbitMQ.Client/src/client/impl/SessionBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,6 @@ public bool IsOpen
get { return CloseReason == null; }
}

IConnection ISession.Connection
{
get { return Connection; }
}

public virtual void OnCommandReceived(Command cmd)
{
CommandReceived?.Invoke(this, cmd);
Expand Down
11 changes: 0 additions & 11 deletions projects/client/Unit/src/unit/APIApproval.Approve.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ namespace RabbitMQ.Client
System.Collections.Generic.IDictionary<string, object> ClientProperties { get; }
string ClientProvidedName { get; }
RabbitMQ.Client.ShutdownEventArgs CloseReason { get; }
RabbitMQ.Client.Impl.ConsumerWorkService ConsumerWorkService { get; }
RabbitMQ.Client.AmqpTcpEndpoint Endpoint { get; }
uint FrameMax { get; }
System.TimeSpan Heartbeat { get; }
Expand Down Expand Up @@ -782,16 +781,6 @@ namespace RabbitMQ.Client.Exceptions
public object Offender { get; }
}
}
namespace RabbitMQ.Client.Impl
{
public class ConsumerWorkService
{
public ConsumerWorkService() { }
public void AddWork(RabbitMQ.Client.IModel model, System.Action fn) { }
public void StopWork() { }
public void StopWork(RabbitMQ.Client.IModel model) { }
}
}
namespace RabbitMQ.Client.Logging
{
[System.Diagnostics.Tracing.EventSource(Name="rabbitmq-dotnet-client")]
Expand Down