Do not contact disconnected nodes in rabbit_nodes:list_running/0 #10353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning/1 As this will force erlang to attempt to set up a distribution connection to the down node. This can take some time, especially in cloud environments.
dumbbell
approved these changes
Jan 17, 2024
kjnilsson
changed the title
Ram nodes are a deprecated feature and the actual assertion is quite a complicated once that isn't easy to reason about as it asserts on the cluster view of nodes that that have their rabbit app stopped.
michaelklishin
force-pushed
the
list-running-opt
branch
from
87664e9 to
ec8942c
Compare
|
This forced push was a rebase. |
|
This has reproducible failures in bt //deps/rabbit:cluster_rename_SUITEDuring the clustering step, one node logs So the implicit connection behavior is important in a few more test suites that actively mess with nodes (kill them, shut them down, rename them). |
|
To further confirm this, editing out the filtering line on this branch immediately makes the above test suite pass :( |
kjnilsson
force-pushed
the
list-running-opt
branch
from
ec8942c to
85f08f0
Compare
dumbbell
reviewed
Jan 18, 2024
dumbbell
approved these changes
Jan 18, 2024
The behaviour of this module is to fragile to potentially allow a regression here so we explicitly ping_all/0 before filtering running nodes.
kjnilsson
force-pushed
the
list-running-opt
branch
from
4f670ca to
d748215
Compare
michaelklishin
added a commit
that referenced
this pull request
Jan 18, 2024
michaelklishin
added a commit
that referenced
this pull request
Jan 18, 2024
Do not contact disconnected nodes in rabbit_nodes:list_running/0 (backport #10353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this will force erlang to attempt to set up a distribution connection to the down node. This can take some time, especially in cloud environments.