Skip to content

Do not contact disconnected nodes in rabbit_nodes:list_running/0 (backport #10353) #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 18, 2024

This is an automatic backport of pull request #10353 done by Mergify.
Cherry-pick of 87664e9 has failed:

On branch mergify/bp/v3.12.x/pr-10353
Your branch is ahead of 'origin/v3.12.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 87664e9fcb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   deps/rabbit/test/clustering_management_SUITE.erl

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ning/1

As this will force erlang to attempt to set up a distribution connection
to the down node. This can take some time, especially in cloud environments.

(cherry picked from commit 8aa2176)
Ram nodes are a deprecated feature and the actual assertion is
quite a complicated once that isn't easy to reason about as it
asserts on the cluster view of nodes that that have their
rabbit app stopped.

(cherry picked from commit 87664e9)

# Conflicts:
#	deps/rabbit/test/clustering_management_SUITE.erl
The behaviour of this module is to fragile to potentially allow a regression
here so we explicitly ping_all/0 before filtering running nodes.

(cherry picked from commit d748215)
@michaelklishin michaelklishin added this to the 3.12.13 milestone Jan 18, 2024
@michaelklishin michaelklishin merged commit 52a73ef into v3.12.x Jan 18, 2024
@michaelklishin michaelklishin deleted the mergify/bp/v3.12.x/pr-10353 branch January 18, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants