Fix a flake in amqp_client_SUITE #11234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`event_recorder` listens for events globally rather than per-connection so it's possible for `connection_closed` and other events from prior test cases to be captured and mixed with the events the test is interested in, causing a flake. Instead we can assert that the events we gather from `event_recorder` contain the ones emitted by the connection.
ansd
reviewed
Sep 13, 2024
| Type =:= EventType andalso | ||
| lists:all( | ||
| fun({Key, _Value}) -> | ||
| lists:keymember(Key, 1, EventProps) |
There was a problem hiding this comment.
This commit removes assertions of the event property values (e.g. <<"/">> and <<"guest">>).
I'm adding the assertions back in #12302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event_recorderlistens for events globally rather than per-connection so it's possible forconnection_closedand other events from prior test cases to be captured and mixed with the events the test is interested in, causing a flake. For example: https://app.buildbuddy.io/invocation/f31d0f74-02f9-407c-887c-838e0952f60a?target=%2F%2Fdeps%2Frabbit%3Aamqp_client_SUITE&targetStatus=6#1Instead we can assert that the events we gather from
event_recordercontain the ones emitted by the connection.