Skip to content

Fix a flake in amqp_client_SUITE (backport #11234) #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 14, 2024

event_recorder listens for events globally rather than per-connection so it's possible for connection_closed and other events from prior test cases to be captured and mixed with the events the test is interested in, causing a flake. For example: https://app.buildbuddy.io/invocation/f31d0f74-02f9-407c-887c-838e0952f60a?target=%2F%2Fdeps%2Frabbit%3Aamqp_client_SUITE&targetStatus=6#1

Instead we can assert that the events we gather from event_recorder contain the ones emitted by the connection.


This is an automatic backport of pull request #11234 done by Mergify.

`event_recorder` listens for events globally rather than per-connection
so it's possible for `connection_closed` and other events from prior
test cases to be captured and mixed with the events the test is
interested in, causing a flake.

Instead we can assert that the events we gather from `event_recorder`
contain the ones emitted by the connection.

(cherry picked from commit 3435a0d)

# Conflicts:
#	deps/rabbit/test/amqp_client_SUITE.erl
Copy link
Author

mergify bot commented May 14, 2024

Cherry-pick of 3435a0d has failed:

On branch mergify/bp/v3.13.x/pr-11234
Your branch is up to date with 'origin/v3.13.x'.

You are currently cherry-picking commit 3435a0d362.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   deps/rabbit/test/amqp_client_SUITE.erl

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@michaelklishin michaelklishin deleted the mergify/bp/v3.13.x/pr-11234 branch May 14, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants