rabbitmq_cli: Improve test node start (backport #12860) #12880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
[Why] The `run-background-broker` does not wait for the node to be ready, leading to some transient errors in the testsuite. [How] The `start-background-broker` does wait. While here, export the value of `$(MAKE)`. Otherwise, nested uses of make(1) may use the wrong make command. (cherry picked from commit e480513)
[Why] Two reasons: 1. ~~We need to set the correct feature flags on the test node we have to start.~~ In 4.0.x, we don't set `$RABBITMQ_FEATURE_FLAGS` because it has no support for +/-feature_flag. 2. We can skip Mnesia- or Khepri-specific tests if they are marked. (cherry picked from commit 0411864)
dumbbell
force-pushed
the
mergify/bp/v4.0.x/pr-12860
branch
from
1a8f1e3 to
1f74193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make several improvements to the way the RabbitMQ test node is started:
$(MAKE)to make sure the correct make command is used by nested instances$RABBITMQ_METADATA_STOREwhen starting the test nodeSee individual commits.
This is an automatic backport of pull request #12860 done by Mergify.