CLI: Error on compiler warnings in tests #12894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously emitted a warning because Elixir will rebind `this_node` by default, so the `this_node` binding in the line above was unused. (As opposed to Erlang which would treat this as a match - rejecting the binding if `this_node` was not equal to the value being matched.) The node needed to be adjusted as well - `node()` returned the ExUnit runner's node while the command returned the remote node, which is stored in the context under `opts.node`.
This check is expected to succeed and the status is expected to be printed to stdout rather than stderr. This change silences the status output. The status text was printed mistakenly previously because we captured stderr rather than stdout.
|
@the-mikedavis do I understand it correctly that this change will be effective for |
|
Yeah this should be limited to Edit: a run of |
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
(cherry picked from commit 9b6ab77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #10459 but focused on
makeinstead. #10459 also only focused on warnings inlib/files while this change causes CLI tests to fail when the test modules contain warnings. We need to add the--warnings-as-errorsflag tomix test(added in Elixir 1.12). We can at the same time check that thelib/files compile without warning by compiling with--warnings-as-errorsas well.Most compiler warnings fixed were benign. The shadowing diagnostics like unused bindings are useful though - one fix covered an unused binding that should've been a match (i.e. needed the pin operator
^).