Skip to content

CLI: Error on compiler warnings in tests #12894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2024
Merged

CLI: Error on compiler warnings in tests #12894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d58d874
CLI: Resolve elixirc warnings
the-mikedavis Dec 4, 2024
c328922
CLI: Fix match of discover peers command test
the-mikedavis Dec 4, 2024
9f60325
CLI: Silence `status` command test
the-mikedavis Dec 4, 2024
430cd2f
CLI: Compile and test with --warnings-as-errors
the-mikedavis Dec 4, 2024
9b6ab77
CLI: test/diagnostics cosmetics #12894
michaelklishin Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/rabbitmq_cli/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ VERBOSE_TEST ?= true
MAX_CASES ?= 1

MIX_TEST_OPTS ?= ""
MIX_TEST = ERL_COMPILER_OPTIONS=deterministic mix test --max-cases=$(MAX_CASES)
MIX_TEST = ERL_COMPILER_OPTIONS=deterministic MIX_ENV=test mix do compile --warnings-as-errors, test --max-cases=$(MAX_CASES) --warnings-as-errors

ifneq ("",$(MIX_TEST_OPTS))
MIX_TEST := $(MIX_TEST) $(MIX_TEST_OPTS)
Expand Down
2 changes: 1 addition & 1 deletion deps/rabbitmq_cli/lib/rabbitmq/cli/auto_complete.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ defmodule RabbitMQ.CLI.AutoComplete do

defp complete_command_opts(command, <<"-", _::binary>> = opt) do
switches =
command.switches
command.switches()
|> Keyword.keys()
|> Enum.map(fn sw -> "--" <> to_string(sw) end)

Expand Down
1 change: 0 additions & 1 deletion .../rabbitmq_cli/test/diagnostics/check_if_any_deprecated_features_are_used_command_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ defmodule CheckIfAnyDeprecatedFeaturesAreUsedCommandTest do

@command RabbitMQ.CLI.Diagnostics.Commands.CheckIfAnyDeprecatedFeaturesAreUsedCommand
@policy_name "cmq-policy-8373"
@policy_value "{\"ha-mode\":\"all\"}"

setup_all do
RabbitMQ.CLI.Core.Distribution.start()
Expand Down
1 change: 0 additions & 1 deletion ...cli/test/diagnostics/check_if_cluster_has_classic_queue_mirroring_policy_command_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ defmodule CheckIfClusterHasClassicQueueMirroringPolicyCommandTest do

@command RabbitMQ.CLI.Diagnostics.Commands.CheckIfClusterHasClassicQueueMirroringPolicyCommand
@policy_name "cmq-policy-8373"
@policy_value "{\"ha-mode\":\"all\"}"

setup_all do
RabbitMQ.CLI.Core.Distribution.start()
Expand Down
4 changes: 2 additions & 2 deletions deps/rabbitmq_cli/test/diagnostics/discover_peers_command_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ defmodule DiscoverPeersCommandTest do

@tag test_timeout: 15000
test "run: returns a list of nodes when the backend isn't configured", context do
this_node = node()
assert match?({:ok, {[this_node], _}}, @command.run([], context[:opts]))
this_node = context.opts.node
assert match?({:ok, {[^this_node], _}}, @command.run([], context[:opts]))
end
end
2 changes: 1 addition & 1 deletion deps/rabbitmq_cli/test/rabbitmqctl_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ defmodule RabbitMQCtlTest do

test "short node name without the host part connects properly" do
command = ["status", "-n", "rabbit"]
capture_io(:stderr, fn -> error_check(command, exit_ok()) end)
capture_io(:stdio, fn -> error_check(command, exit_ok()) end)
end

test "a non-existent command results in help message displayed" do
Expand Down
Loading