Re-introduce consumer bias & set to 2.0 #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2017 17:05
…uickly" This reverts commit 155eb6b.
[#152235655]
michaelklishin
approved these changes
Oct 26, 2017
gerhard
reviewed
Oct 27, 2017
|
Following #1378, we have observed that when using PerfTest, always prioritising consumers results in publishers being blocked most of the time. This is less than ideal. We have settled on making consumers 2x as fast as publishers. No consumer bias
2x consumer bias
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #1378 because it leads to performance degradation for publishers.
Set consumer bias to 2.0 to prioritise consumers.