Skip to content

Make the AddressResolver more generic #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Dec 8, 2022

Add AddressResolver(EndPoint endPoint) in this way can accept DNS and IP endpoints

See also #188

you can now use:

var addressResolver = new AddressResolver(new IPEndPoint(IPAddress.Parse("192.168.10.99"), 5552));

and

var addressResolver = new AddressResolver(new DnsEndPoint("MyDnsEntryPoint", 5552));

Signed-off-by: Gabriele Santomaggio [email protected]

Add AddressResolver(EndPoint endPoint) in this way can accept DNS and IP endpoints

See also #188

Signed-off-by: Gabriele Santomaggio <[email protected]>
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 92.80% // Head: 92.69% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (e46e21b) compared to base (20ba4b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   92.80%   92.69%   -0.12%     
==========================================
  Files          94       94              
  Lines        8005     8017      +12     
  Branches      597      598       +1     
==========================================
+ Hits         7429     7431       +2     
- Misses        468      476       +8     
- Partials      108      110       +2     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/AddressResolver.cs 100.00% <100.00%> (ø)
Tests/UnitTests.cs 98.10% <100.00%> (+0.11%) ⬆️
RabbitMQ.Stream.Client/Connection.cs 89.16% <0.00%> (-2.50%) ⬇️
RabbitMQ.Stream.Client/Reliable/Producer.cs 83.58% <0.00%> (-2.24%) ⬇️
RabbitMQ.Stream.Client/LogEventSource.cs 98.36% <0.00%> (-1.64%) ⬇️
RabbitMQ.Stream.Client/RawProducer.cs 82.79% <0.00%> (-1.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@lukebakken lukebakken added this to the 1.0.0 milestone Dec 8, 2022
@lukebakken lukebakken merged commit 255a182 into main Dec 8, 2022
@lukebakken lukebakken deleted the change_address_resolver branch December 8, 2022 19:56
lukebakken pushed a commit that referenced this pull request Dec 14, 2022
Add AddressResolver(EndPoint endPoint) in this way can accept DNS and IP endpoints

See also #188

Signed-off-by: Gabriele Santomaggio <[email protected]>

Signed-off-by: Gabriele Santomaggio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants