Skip to content

Make the AddressResolver more generic #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Make the AddressResolver more generic #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RabbitMQ.Stream.Client/AddressResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ namespace RabbitMQ.Stream.Client
{
public class AddressResolver
{
public AddressResolver(IPEndPoint endPoint)
public AddressResolver(EndPoint endPoint)
{
EndPoint = endPoint;
Enabled = true;
}

public IPEndPoint EndPoint { get; set; }
public EndPoint EndPoint { get; set; }
public bool Enabled { get; set; }
}
}
4 changes: 2 additions & 2 deletions RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ RabbitMQ.Stream.Client.AbstractEntity
RabbitMQ.Stream.Client.AbstractEntity.AbstractEntity() -> void
RabbitMQ.Stream.Client.AbstractEntity._client -> RabbitMQ.Stream.Client.Client
RabbitMQ.Stream.Client.AddressResolver
RabbitMQ.Stream.Client.AddressResolver.AddressResolver(System.Net.IPEndPoint endPoint) -> void
RabbitMQ.Stream.Client.AddressResolver.AddressResolver(System.Net.EndPoint endPoint) -> void
RabbitMQ.Stream.Client.AddressResolver.Enabled.get -> bool
RabbitMQ.Stream.Client.AddressResolver.Enabled.set -> void
RabbitMQ.Stream.Client.AddressResolver.EndPoint.get -> System.Net.IPEndPoint
RabbitMQ.Stream.Client.AddressResolver.EndPoint.get -> System.Net.EndPoint
RabbitMQ.Stream.Client.AddressResolver.EndPoint.set -> void
RabbitMQ.Stream.Client.AMQP.AmqpParseException
RabbitMQ.Stream.Client.AMQP.AmqpParseException.AmqpParseException(string s) -> void
Expand Down
16 changes: 16 additions & 0 deletions Tests/UnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,22 @@ public void AddressResolverLoadBalancerSimulate()
}
}

[Fact]
public void DnsAddressResolverLoadBalancerSimulate()
{
var addressResolver = new AddressResolver(new DnsEndPoint("MyDnsEntryPoint", 5552));
var clientParameters = new ClientParameters() { AddressResolver = addressResolver, };
var metaDataInfo = new StreamInfo("stream", ResponseCode.Ok, new Broker("node2", 5552),
new List<Broker>() { new Broker("node1", 5552), new Broker("node3", 5552) });
// run more than one time just to be sure to use all the IP with random
for (var i = 0; i < 4; i++)
{
var client = RoutingHelper<LoadBalancerRouting>.LookupLeaderConnection(clientParameters, metaDataInfo);
Assert.Equal("node2", client.Result.ConnectionProperties["advertised_host"]);
Assert.Equal("5552", client.Result.ConnectionProperties["advertised_port"]);
}
}

[Fact]
public async Task RoutingHelperShouldThrowIfLoadBalancerIsMisconfigured()
{
Expand Down