Stop catching Nokogiri::CSS::SyntaxError #53
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
This will require an update to |
|
👍. Could you update the README? |
|
Nice 👍 — definitely forgot this for 2.0. Ping me when you've updated the README, then I'll merge and release 2.0.1 😁 |
davidcornu
force-pushed
the
raise-on-nokogiri-css-error
branch
from
0fa540c to
10faac9
Compare
|
@kaspth README has been updated |
|
🎉 |
|
Thanks so much! ❤️ Shipped in https://github.com/rails/rails-dom-testing/releases/tag/v2.0.1 |
Skipping over an assertion in the hopes the developer will see the deprecation warning seems like the wrong approach to this.
cc @rafaelfranca