Deprecate assert_select* in preparation for rename #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is a companion PR to [rails/rails#41291][]. While it's possible that [rails/rails#41291][] may make Capybara assertion integration possible, there is still a possibility that applications would continue to use rails-dom-testing (or both!) to make assertions about HTML. Capybara also declares an `assert_select` method and while the method names collide, "select" in one case means CSS selector while "select" means `<select>` elements in the other. Since the tool itself includes `dom` in the package name, and includes `assert_dom_equal` helpers already, renaming `assert_select` and its other variations to methods starting with `assert_dom` unifies the interface. [rails/rails#41291]: rails/rails#41291
seanpdoyle
added a commit
to seanpdoyle/rails-dom-testing
that referenced
this pull request
Feb 16, 2021
seanpdoyle
commented
Feb 16, 2021
| @@ -178,6 +178,7 @@ def assert_select(*args, &block) | |||
| nest_selection(matches, &block) if block_given? && !matches.empty? | |||
| end | |||
| end | |||
| deprecate assert_select: "assert_select will be renamed to assert_dom in an upcoming release" | |||
There was a problem hiding this comment.
Do we think that assert_css_select or assert_dom_select is a more communicative new name than assert_dom?
|
Blam! |
|
Benefitting from that leftover Active Support deprecation require 😂 |
seanpdoyle
added a commit
to seanpdoyle/rails-dom-testing
that referenced
this pull request
Feb 18, 2021
Bridge the gap between [rails#91][] (shipped) and [rails#92][] (open) by declaring [alias_method][] expressions for each `assert_select` variation, adding `assert_dom` variations to the interface. [rails#91]: rails#91 [rails#92]: rails#92 [alias_method]: https://docs.ruby-lang.org/en/3.0.0/Module.html#method-i-alias_method
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Feb 19, 2021
On the heels of [rails/rails-dom-testing#91][] and [rails/rails-dom-testing#93][], and in preparation for [rails/rails-dom-testing#92][] [rails/rails-dom-testing#91]: rails/rails-dom-testing#91 [rails/rails-dom-testing#92]: rails/rails-dom-testing#92 [rails/rails-dom-testing#93]: rails/rails-dom-testing#93
smartech7
pushed a commit
to smartech7/dom-testing-ruby
that referenced
this pull request
Aug 4, 2023
Bridge the gap between [#91][] (shipped) and [#92][] (open) by declaring [alias_method][] expressions for each `assert_select` variation, adding `assert_dom` variations to the interface. [#91]: rails/rails-dom-testing#91 [#92]: rails/rails-dom-testing#92 [alias_method]: https://docs.ruby-lang.org/en/3.0.0/Module.html#method-i-alias_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a companion PR to rails/rails#41291. While it's
possible that rails/rails#41291 may make Capybara assertion
integration possible, there is still a possibility that applications
would continue to use rails-dom-testing (or both!) to make assertions
about HTML.
Capybara also declares an
assert_selectmethod and while the methodnames collide, "select" in one case means CSS selector while "select"
means
<select>elements in the other.Since the tool itself includes
domin the package name, and includesassert_dom_equalhelpers already, renamingassert_selectand itsother variations to methods starting with
assert_domunifies theinterface.