Remove deprecation, document alias #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't we need an What's Rails' and Rails apps' upgrade path for this change? Just bumping the required version in the Gemfile? |
seanpdoyle
added a commit
to seanpdoyle/rails-dom-testing
that referenced
this pull request
Feb 18, 2021
Bridge the gap between [rails#91][] (shipped) and [rails#92][] (open) by declaring [alias_method][] expressions for each `assert_select` variation, adding `assert_dom` variations to the interface. [rails#91]: rails#91 [rails#92]: rails#92 [alias_method]: https://docs.ruby-lang.org/en/3.0.0/Module.html#method-i-alias_method
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Feb 19, 2021
On the heels of [rails/rails-dom-testing#91][] and [rails/rails-dom-testing#93][], and in preparation for [rails/rails-dom-testing#92][] [rails/rails-dom-testing#91]: rails/rails-dom-testing#91 [rails/rails-dom-testing#92]: rails/rails-dom-testing#92 [rails/rails-dom-testing#93]: rails/rails-dom-testing#93
|
Do we need to remove |
seanpdoyle
force-pushed
the
rename-assert-select-to-assert-dom
branch
from
529aebe to
3d2cc8d
Compare
seanpdoyle
changed the title
|
@rafaelfranca that seems like a more straightforward compromise. I've switched this branch to remove the deprecations, but I've kept the documentation changes in place to encourage usage of the |
|
@rafaelfranca I've rolled back the majority of rails/rails#41500 to take a similar approach. |
Remove all deprecations of `assert_select`-prefixed methods, but document the `assert_dom` variations.
seanpdoyle
force-pushed
the
rename-assert-select-to-assert-dom
branch
from
3d2cc8d to
844bf49
Compare
smartech7
pushed a commit
to smartech7/dom-testing-ruby
that referenced
this pull request
Aug 4, 2023
Bridge the gap between [#91][] (shipped) and [#92][] (open) by declaring [alias_method][] expressions for each `assert_select` variation, adding `assert_dom` variations to the interface. [#91]: rails/rails-dom-testing#91 [#92]: rails/rails-dom-testing#92 [alias_method]: https://docs.ruby-lang.org/en/3.0.0/Module.html#method-i-alias_method
morgoth
added a commit
to tiramizoo/rails
that referenced
this pull request
Jan 21, 2025
One is the alias of the other, but assert_select is a confusing name in presence of the assert_selector method (from Capybara). This is a follow up to rails#54299 (comment) and rails/rails-dom-testing#92 (comment) [ci skip]
morgoth
added a commit
to tiramizoo/rails
that referenced
this pull request
Jan 21, 2025
One is the alias of the other, but assert_select is a confusing name in presence of the assert_selector method (from Capybara). Also there is a conflicting `assert_select` on the Capybara itself https://rubydoc.info/github/teamcapybara/capybara/master/Capybara%2FMinitest%2FAssertions:assert_select This is a follow up to rails#54299 (comment) and rails/rails-dom-testing#92 (comment) [ci skip]
morgoth
added a commit
to tiramizoo/rails
that referenced
this pull request
Jan 21, 2025
One is the alias of the other, but assert_select is a confusing name in presence of the assert_selector method (from Capybara). Also there is a conflicting `assert_select` on the Capybara itself https://rubydoc.info/github/teamcapybara/capybara/master/Capybara%2FMinitest%2FAssertions:assert_select This is a follow up to rails#54299 (comment) and rails/rails-dom-testing#92 (comment) [ci skip] Co-authored-by: Petrik de Heus <[email protected]>
mrpasquini
pushed a commit
to mrpasquini/rails
that referenced
this pull request
Jan 23, 2025
One is the alias of the other, but assert_select is a confusing name in presence of the assert_selector method (from Capybara). Also there is a conflicting `assert_select` on the Capybara itself https://rubydoc.info/github/teamcapybara/capybara/master/Capybara%2FMinitest%2FAssertions:assert_select This is a follow up to rails#54299 (comment) and rails/rails-dom-testing#92 (comment) [ci skip] Co-authored-by: Petrik de Heus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all deprecations of
assert_select-prefixed methods, butdocument the
assert_domvariations.