feat(iOS): Toggle backup feature #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
commented
Oct 8, 2020
tido64
requested changes
Oct 13, 2020
|
We're already moved 🧙♀️ |
|
@krizzu -- since this is a global setting, you could expose a native method in a header and allow people to configure the storage mode globally from their AppDelegate.m ? -- I think this is okay since this doesn't apply to Android. Additionally, I think since this was a regression, the default should be "don't-store-in-backup" and instead people would have to opt-in to include AsyncStorage in Backup Thoughts? |
Feature flag "AsyncStorage_excludeFromBackup" in info.plist will enable/disable exclusion from iCloud storage. Excluded by default.
tido64
reviewed
Oct 15, 2020
tido64
reviewed
Oct 15, 2020
I don't know how the community will use this feature (and how often it is used) so I'm fine with the current approach (for now 😏) |
I think that setting a feature flag in How often? ¯_(ツ)_/¯ I I expect not at all, but let's just leave this as an option |
tido64
approved these changes
Oct 17, 2020
tido64
approved these changes
Oct 18, 2020
fbartho
approved these changes
Oct 20, 2020
|
Going to do a release today - under a new org though, we need to deprecate old RNCommunity package |
5 tasks
craigzour
pushed a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Mar 29, 2021
…" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install
craigzour
pushed a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Mar 29, 2021
…" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install
craigzour
pushed a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Mar 31, 2021
…" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install
craigzour
pushed a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Apr 7, 2021
…" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install
craigzour
pushed a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Apr 7, 2021
…" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install
craigzour
added a commit
to cds-snc/covid-alert-app
that referenced
this pull request
Apr 8, 2021
* Update the dependency "@react-native-community/async-storage": "1.9.0" to "@react-native-async-storage/async-storage ^1.9.0" Remove the now unneeded @react-native-community+async-storage+1.9.0.patch - As per react-native-async-storage/async-storage#455 files should not be stored in iCloud backup by default Results of yarn install * Results of bundle install - with the move to react-native-async-storage * Search/replace @react-native-community/async-storage with @react-native-async-storage/async-storage * Update settings.gradle for the move to @react-native-async-storage * Introduced KeyValueStore (with secure and unsecure implementation) in StorageService * Introduced new StorageService (FutureStorageService as a temporary name) * Replaced SecureKeyValueStore with new StorageService solution in MetricsService * Replaced SecureKeyValueStore with new StorageService solution in OutbreakProvider * Replaced RNSecureKeyStore with new StorageService solution in ExposureNotificationService * Replaced RNSecureKeyStore with new StorageService solution in PollNotificationService * Replaced AsyncStorage with new StorageService solution in existing StorageService * Replaced AsyncStorage with new StorageService solution in BackendService * Replaced AsyncStorage with new StorageService solution in ExposureNotificationService * Replaced AsyncStorage with new StorageService solution in PollNotificationService * Replaced AsyncStorage with new StorageService solution in OutbreakProvider * Replaced AsyncStorage with new StorageService solution in many simple spots * Added deleteAll function on new StorageService to plug it in the reset function of the debug menu * Renamed StorageService to CachedStorageService and StorageServiceProvider to CachedStorageServiceProvider * Renamed FutureStorageService to StorageService * Added unit tests to new StorageService Co-authored-by: Robert Shand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addressing #342
I could not reproduce this myself. Saving data, forcing iCloud backup, removing and installing again does not retain the data. This is mostly for anyone who can successfully reproduce the issue mentioned in #342.
Test Plan: