Skip to content

feat(iOS): Toggle backup feature #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2020
Merged

feat(iOS): Toggle backup feature #455

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
576f7c0
feat: disable backup for AsyncStorage
Oct 8, 2020
3c71c86
fix: review suggestions
Oct 13, 2020
3db0b42
fix: add feature flag to info.plist
Oct 15, 2020
c6a6540
fix: review
Oct 17, 2020
50a73df
docs: feature description
Oct 18, 2020
67f7cd3
docs: correction
Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions ios/RNCAsyncStorage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,26 @@
}
}

static BOOL RCTAsyncStorageSetExcludedFromBackup(NSString* path, NSNumber* isExcluded)
{
NSFileManager *fileManager = [[NSFileManager alloc] init];

BOOL isDir;
BOOL exists = [fileManager fileExistsAtPath:path isDirectory:&isDir];
BOOL success = false;

if (isDir && exists) {
NSURL* pathUrl = [NSURL fileURLWithPath:path];
NSError *error = nil;
success = [pathUrl setResourceValue:isExcluded forKey:NSURLIsExcludedFromBackupKey error:&error];

if (!success) {
NSLog(@"Could not exclude AsyncStorage dir from backup %@", error);
}
}
return success;
}

static void RCTAppendError(NSDictionary *error, NSMutableArray<NSDictionary *> **errors)
{
if (error && errors) {
Expand Down Expand Up @@ -393,6 +413,14 @@ - (NSDictionary *)_ensureSetup
}

if (!_haveSetup) {
// iCloud backup exclusion
NSNumber* isExcludedFromBackup = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"RCTAsyncStorageExcludeFromBackup"];
if (isExcludedFromBackup == nil) {
// by default, we want to exclude AsyncStorage data from backup
isExcludedFromBackup = @YES;
}
RCTAsyncStorageSetExcludedFromBackup(RCTCreateStorageDirectoryPath(RCTStorageDirectory), isExcludedFromBackup);

NSDictionary *errorOut = nil;
NSString *serialized = RCTReadFile(RCTCreateStorageDirectoryPath(RCTGetManifestFilePath()), RCTManifestFileName, &errorOut);
if (!serialized) {
Expand Down