Moving to TypeScript #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvinis
added
enhancement
|
This is ready to be reviewed! I fixed a bunch of types, and now you can do |
src/useKeyboard.ts
Outdated
| const keyboardDidHideListener = Keyboard.addListener('keyboardDidHide', handleKeyboardDidHide) | ||
|
|
||
| return () => { | ||
| keyboardWillShowListener.remove() |
There was a problem hiding this comment.
Can you fix this reformat ?
|
@dabit3 Can you check this PR ? I think everything is fine. |
|
I didn't bother formatting because I saw a PR adding eslint, but yes, I can run a prettier in this or something. |
|
Should I throw a prettierrc in here, or just run it? |
|
Nah, I will not add prettier or eslint here, I just run it and it's good for now. We should make a different PR for adding these tools. |
This was referenced Nov 1, 2019
Closed
Closed
|
Bump! This should be ready to review again and merge if approved. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should finally move this to typescript. Here is the first pass.
I added typescript and the react and react native types, I made a base config, I added
filesin package.json, I renamed all files, and I fixed the errors.To compile we do
yarn build, and this should also happen beforenpm publish, we can add it in aprepublish.Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)