Install cargo-ament-build with --debug in CI #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is faster than the release build. Also print the current path in check steps.
nnmm
changed the title
|
The only thing I'm concerned about is any potential differences between the debug and release versions of the code - there may not be a change at the moment, but it's theoretically possible there could be an accidental difference in the future, right? |
|
Well, if anything, using the debug build makes it easier to spot errors (debug_assert etc.). |
|
I suppose that is fair. Plus, this crate is mostly used in construction - the runtime performance hit of debug mode shouldn't affect CI too much... |
jhdcs
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster than the release build.
Also print the current path in check steps.