-
Notifications
You must be signed in to change notification settings - Fork 162
Add detailed guide for building ros2_rust packages #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a partial review at the moment, I'll have to look at the rest later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more suggested changes. That being said, I like how this is turning out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for not catching this one earlier...
Co-authored-by: jhdcs <[email protected]>
@nnmm the |
@esteve if you look up a newer article, GitHub also checks the |
@nnmm you're right about the |
Yep, it's uppercase now. |
@esteve Do you have any further comments? |
@nnmm that was all, thanks for addressing my feedback 🙂 |
Also extend contributing.md and condense the readme a bit. See here for a rendered version.