Skip to content

Removes cd to /src from instructions in README. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jpace121
Copy link

@jpace121 jpace121 commented May 4, 2022

Hi!

I recently started trying out ros2-rust and was following the instructions in the README to get started.

I noticed this line that seemingly tried to cd to /src, which I don't think is the intended instruction...

Thanks!

James

We normally call (and probably want to call) colcon from the root of the workspace
and not ./src (and definitely not /src).
@jpace121 jpace121 force-pushed the remove-extra-cd-from-readme branch from 98a644d to e1cba1f Compare May 4, 2022 00:58
@nnmm
Copy link
Contributor

nnmm commented May 4, 2022

I think the intent was to cd src, without the leading slash. Then it should work, though the naming of the directory isn't optimal. If this line is removed altogether, the instructions won't work if the working directory is '/'.

#129 solves these problems, but it hasn't been merged yet. So, I suggest to either make this cd src, or wait for the other PR to get merged.

@jpace121
Copy link
Author

jpace121 commented May 4, 2022

I’m cool waiting for #129.

I don’t think the intent was to call colcon build in src though. That seems like a weird way to call colcon that doesn’t really lineup with how it’s used other places.

@nnmm
Copy link
Contributor

nnmm commented May 4, 2022

Agree, it is quite weird, but it was added as a quick fix for the case where the working directory is / - and I didn't look closely enough during the review. You can see it in the git history.

OK, then let's close this. Thanks for submitting the fix though.

@nnmm nnmm closed this May 4, 2022
@esteve esteve reopened this May 5, 2022
@esteve
Copy link
Collaborator

esteve commented May 5, 2022

@jpace121 thanks for submitting the fix, running from src was definitely not intended. @nnmm until #129 is merged, this one will do, having the workspace on / is a quite weird scenario, I'm assuming that's from a Docker container, in which case the workspace should still be in a different folder, not the root

@nnmm
Copy link
Contributor

nnmm commented May 19, 2022

#129 is merged, closing this.

@nnmm nnmm closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants