Skip to content

Remove unnecessary casts to raw pointers #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2022
Merged

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Apr 28, 2022

The references automatically coerce to raw pointers.

This also improves the signal-to-noise ratio on the as keyword, which is often an
antipattern (e.g. for many numeric casts).

The references automatically coerce to raw pointers.

This also improves the signal-to-noise ratio on the `as` keyword, which is often an
antipattern (e.g. for many numeric casts).
@nnmm nnmm requested review from jhdcs and esteve April 28, 2022 19:18
esteve
esteve previously approved these changes Apr 29, 2022
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnmm this makes code more readable, thanks!

jhdcs
jhdcs previously approved these changes Apr 29, 2022
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now that CI is passing!

@nnmm nnmm merged commit cb87f98 into master May 2, 2022
@nnmm nnmm deleted the remove_unnecessary_casts branch May 2, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants