Add functions to get topic name to publisher and subscriber

[DS3a]

A new variable was added to the struct to store the topic name in a boxed string.

[nnmm]

Welcome to the ros2-rust project @DS3a!

This implementation is probably based on a misunderstanding of #148: The functions rcl_subscription_get_topic_name and rcl_publisher_get_topic_name already exist, in the rcl_bindings module (they come from the rcl package). You should call them to fetch the string. The reason is that these functions return the topic name after remapping, and not just the topic name that was passed in. See #143 for more context, and for an example of how to deal with C strings.

[jhdcs]

Additionally, it looks like your commits were not able to be verified. Would you be able to look into that? That will need to be fixed before we can merge.

[nnmm]

Is it a requirement @jhdcs?

[jhdcs]

Now that I look at it again, it does not appear to be for us... However, I believe that other ROS 2 projects (such as the client libraries) require it as part of the DCO check.

[DS3a]

Additionally, it looks like your commits were not able to be verified. Would you be able to look into that? That will need to be fixed before we can merge.

Aight... I'll look into that.

[DS3a]

Welcome to the ros2-rust project @DS3a!

This implementation is probably based on a misunderstanding of #148: The functions rcl_subscription_get_topic_name and rcl_publisher_get_topic_name already exist, in the rcl_bindings module (they come from the rcl package). You should call them to fetch the string. The reason is that these functions return the topic name after remapping, and not just the topic name that was passed in. See #143 for more context, and for an example of how to deal with C strings.

Ahhh... My bad... I'll change it accordingly

[DS3a]

Hi... I've made the required changes, and verified my GPG key, can you look it over and see if there's any changes to be made?

[DS3a]

A self review has been done... This is my first PR, forgive me for having to be reminded of the protocol

[nnmm]

Thanks for adjusting, the PR looks good in general now, though I have a couple of comments.

As you can see, our CI checks formatting and clippy, so make sure to run cargo fmt and cargo clippy as well.

[jhdcs]

A self review has been done... This is my first PR, forgive me for having to be reminded of the protocol

No worries! We all start somewhere! Thank you for taking the time to try and make ros2_rust a little better! We really appreciate it!

[nnmm]

@DS3a I noticed you did something different than I suggested. Did the suggestion not work?

[nnmm]

@DS3a Are you sure you tried with into_owned() instead of to_owned()? They are different methods.

[DS3a]

@DS3a Are you sure you tried with into_owned() instead of to_owned()? They are different methods.

Ohhh... I didn't notice that... Hold on... I'll push the changes soon

[DS3a]

okay... I've made changes to return String instead of Result<String, Err>

[nnmm]

Looks good to me. Thanks for your patience @DS3a!

[DS3a]

Looks good to me. Thanks for your patience @DS3a!

Thanks... I look forward to contributing more to ros2_rust!!

[esteve]

@DS3a thanks for you contribution! 🙂