Add new node name-related functions #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nnmm
commented
May 1, 2022
nnmm
commented
- Add Node::name, Node::namespace, Node::fully_qualified_name getters
- Add Context::create_node_with_namespace function
- Swap order of namespace and name argument in Node::new_with_namespace, so that it's less confusing
- Add Node::name, Node::namespace, Node::fully_qualified_name getters - Add Context::create_node_with_namespace function - Swap order of namespace and name argument in Node::new_with_namespace, so that it's less confusing
esteve
reviewed
May 2, 2022
| self.get_string(rcl_node_get_fully_qualified_name) | ||
| } | ||
|
|
||
| fn get_string( |
There was a problem hiding this comment.
This looks like a good candidate for a macro, IMHO
There was a problem hiding this comment.
I don't care much either way in this instance, but the approach using a function could be said to have a few advantages:
- Less code size (obviously doesn't matter much for such a small function)
- No need to know
macro_rules! - Better IDE support
- You can see the type of the function supported by the helper
- Definition of the helper is closer to the call site (since macro would typically be at the top level)
There was a problem hiding this comment.
It's a little less efficient though, but I think for these functions that won't matter.
There was a problem hiding this comment.
Yeah, that makes sense. I was just thinking of #141 and how to integrate it with this, though.
There was a problem hiding this comment.
Yes, that's something we'll need to think about. Maybe call_ffi!(getter, …) will already work if the right token type is used.
esteve
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.