Skip to content

Install cargo-ament-build with --debug #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented May 29, 2022

We already do this in CI, users should also not need an optimized cargo-ament-build

@nnmm nnmm requested a review from jhdcs May 29, 2022 12:28
@@ -35,7 +35,7 @@ Here are the steps for building the `ros2_rust` examples in a vanilla Ubuntu Foc
# Assuming you installed the minimal version of ROS 2, you need these additional packages:
sudo apt install -y git libclang-dev python3-pip python3-vcstool # libclang-dev is required by bindgen
# Install these plugins for cargo and colcon:
cargo install cargo-ament-build
cargo install --debug cargo-ament-build # --debug is faster to install
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it faster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, cargo install compiles with optimizations enabled, which takes much longer. The time spent in cargo-ament-build itself is minimal, so I think having a snappier setup is worth not having these optimizations.

@nnmm nnmm merged commit da6cd4f into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the cargo-ament-build-debug branch May 30, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants