Skip to content

Rename get_topic to topic_name #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Rename get_topic to topic_name #209

merged 1 commit into from
Jun 27, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Jun 26, 2022

This is to be consistent with the prevalent style, which is not to use "get_" prefixes for getters.

@nnmm nnmm requested a review from a team June 26, 2022 08:17
@nnmm nnmm merged commit a37705c into main Jun 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the topic_name branch June 27, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants