Skip to content

Rename get_topic to topic_name #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclrs/src/node/publisher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ where
///
/// This returns the topic name after remapping, so it is not necessarily the
/// topic name which was used when creating the publisher.
pub fn get_topic(&self) -> String {
pub fn topic_name(&self) -> String {
// SAFETY: No preconditions for the functions called.
// The unsafe variables created get converted to safe types before being returned
unsafe {
Expand Down
2 changes: 1 addition & 1 deletion rclrs/src/node/subscription.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ where
///
/// This returns the topic name after remapping, so it is not necessarily the
/// topic name which was used when creating the subscription.
pub fn get_topic(&self) -> String {
pub fn topic_name(&self) -> String {
// SAFETY: No preconditions for the function used
// The unsafe variables get converted to safe types before being returned
unsafe {
Expand Down