-
Notifications
You must be signed in to change notification settings - Fork 356
Support for reconnectable, shared Mono<RSocket> #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ff8f41
to
ce7f507
Compare
cc\ @rstoyanchev @simonbasle @linux-china @smaldini @yschimke for your review folks |
ce7f507
to
c7642b3
Compare
323d885
to
9dd3db1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor points on the API, otherwise looks good to me
c35cb41
to
0643efb
Compare
Looks great, exposed through I'm wondering about using the new Retry from reactor-core which has some very nice built-in options. For |
@rstoyanchev no-args Do you think such an extension (with no retry) is unnecessary?
Retry is now a convenient way to do retry, so I'm going to replace function with that one shortly |
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
0643efb
to
72ab2d7
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
17ae73d
to
6957a43
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
74a819c
to
26a3548
Compare
* assert r4 == r3; | ||
* | ||
* }</pre> | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would also be worth mentioning or showing that downstream subscribers (i.e. individual requests) are expected to have retry logic, according to their own needs, in order to trigger a reconnect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Rossen Stoyanchev <[email protected]>
ac7fcfe
to
d1fb0ec
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
d1fb0ec
to
8523b1e
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
This PR enables a reconnectable RSocket Mono feature which allows to:
Mono
instance without extra effort (extra effort ==mono.cache()
)ReconnectMono#block
) as in the case ofMonoProcessor
Mono
which reestablishes connection once the previous has been expiredSigned-off-by: Oleh Dokuka [email protected]