Pre-validate Payload length at stream level to avoid closing connection #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
3 times, most recently
from
b21e1b9 to
1c05255
Compare
OlegDokuka
force-pushed
the
bugfix/request_channel
branch
2 times, most recently
from
5339a88 to
268e1ae
Compare
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
1c05255 to
a124aea
Compare
simonbasle
requested changes
Apr 6, 2020
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationUtils.java
Outdated
Show resolved
Hide resolved
rstoyanchev
requested changes
Apr 8, 2020
rsocket-core/src/main/java/io/rsocket/fragmentation/FragmentationUtils.java
Outdated
Show resolved
Hide resolved
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
09686c2 to
5921ef3
Compare
OlegDokuka
force-pushed
the
bugfix/request_channel
branch
from
268e1ae to
ab0ce37
Compare
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
5921ef3 to
d4a9633
Compare
|
Deferred until #736 |
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
225c0d9 to
c4f56e3
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
0ac7944 to
22ee087
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/frame-length-validation
branch
from
22ee087 to
f8676af
Compare
rstoyanchev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provide extra payload validation in order to avoid later exception throwing if frame length exists allowed size for with disabled fragmentation