This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Support rake 11.x #2197
Merged
Support rake 11.x #2197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `Rake.application.last_comment` has been removed in favor of `Rake.application.last_description`
yujinakayama
added a commit
that referenced
this pull request
Mar 9, 2016
... so that we can notice when any breaking change is introduced in a major version bump of rake. Ref: #2197
Merged
|
LGTM 👍 Thanks for the fix! |
|
Thank you for this patch. 👍 |
yujinakayama
added a commit
that referenced
this pull request
Mar 9, 2016
|
+1 |
yujinakayama
added a commit
that referenced
this pull request
Mar 9, 2016
... so that we can notice when any breaking change is introduced in a major version bump of rake. Ref: #2197
yujinakayama
added a commit
that referenced
this pull request
Mar 9, 2016
|
@tjgrathwell @yujinakayama Thanks for your works. I appreciate rspec core team for Rake 11 breaking changes. |
Now we're preparing for the patch release. |
fables-tales
pushed a commit
that referenced
this pull request
Mar 9, 2016
This is so that we can release #2197
|
rspec-core 3.4.4 is now released. |
|
It works great, thank you all! 💯 |
weppos
added a commit
to dnsimple/dnsimple-ruby
that referenced
this pull request
Mar 9, 2016
See rspec/rspec-core#2197 Thanks @tjgrathwell for the quick fix. /cc @jodosha
|
This is nice commit 👍 |
tricknotes
pushed a commit
to tricknotes/rspec-core
that referenced
this pull request
Mar 9, 2016
... so that we can notice when any breaking change is introduced in a major version bump of rake. Ref: rspec#2197
I sent a PR #2202. |
mattbrictson
added a commit
to mattbrictson/capistrano
that referenced
this pull request
Mar 10, 2016
|
How about adding this to 3.5 beta? We're working on rails 5 and rspec 3.4 does not support it. |
|
|
h-lame
added a commit
to alphagov/licence-finder
that referenced
this pull request
Apr 13, 2016
This protects us against cve-2016-2098 and cve-2016-2097[1]. We also upgrade rspec-rails to 3.4.x to avoid a deprecation warning caused by it using an older part of the rake API[2]. [1]: http://www.securitytracker.com/id/1035122 [2]: rspec/rspec-core#2197
benlovell
added a commit
to guidance-guarantee-programme/pension_guidance
that referenced
this pull request
Apr 20, 2016
RSpec was spewing a deprecation warning thanks to recent changes in the Rake API. This resolves those issues. See: rspec/rspec-core#2197
benlovell
added a commit
to guidance-guarantee-programme/output
that referenced
this pull request
Apr 21, 2016
RSpec was spewing a deprecation warning thanks to recent changes in the Rake API. This resolves those issues. See: rspec/rspec-core#2197
Vincent--
added a commit
to RewardGateway/puppet-nessus
that referenced
this pull request
Dec 22, 2016
They were already present in rspec-puppet. This shoud fix `undefined method `last_comment'` during Travis run NB: rake 11.0+ requires rspec > 3.4.4 (see rspec/rspec-core#2197)
This was referenced Dec 22, 2016
surminus
added a commit
to gds-operations/vcloud-core
that referenced
this pull request
May 26, 2017
the last_comment method was removed in Rake, and this is fixed in a later version of rspec. Ref: rspec/rspec-core#2197
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
... so that we can notice when any breaking change is introduced in a major version bump of rake. Ref: rspec#2197
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Support rake 11.x
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
added a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
... so that we can notice when any breaking change is introduced in a major version bump of rake. Ref: rspec/rspec-core#2197 --- This commit was imported from rspec/rspec-core@cb00881.
yujinakayama
added a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-core@fcd716b.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This is so that we can release rspec/rspec-core#2197 --- This commit was imported from rspec/rspec-core@580136d.
mikejohn857
added a commit
to mikejohn857/angular-capistrano-project
that referenced
this pull request
Nov 25, 2022
dazralsky
pushed a commit
to dazralsky/capistrano
that referenced
this pull request
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Rake.application.last_commenthas been removedin favor of
Rake.application.last_descriptionRemoval commit from rake: ruby/rake@e76242c
last_commenthas been deprecated in favor oflast_descriptionsince 2007 (rake 0.7.4):ruby/rake@d1f89d7