Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Support rake 11.x for rspec-core 2.99 #2202

Closed
wants to merge 2 commits into from

Conversation

tricknotes
Copy link

This is the same fixes with #2197 for 2-99-maintenance branch.

tjgrathwell and others added 2 commits March 9, 2016 23:39
The method `Rake.application.last_comment` has been removed
in favor of `Rake.application.last_description`
... so that we can notice when any breaking change is introduced in a
major version bump of rake.

Ref: rspec#2197
@tricknotes tricknotes mentioned this pull request Mar 9, 2016
@myronmarston
Copy link
Member

@tricknotes is there a reason you can't just upgrade to RSpec 3.4? RSpec 2.99 is meant only to be a stepping stone to help users upgrade to RSpec 3 and is not intended to be a version users stick around on. What you have here looks OK but there are travis build issues (unsurprising, given how long it's been since we've done anything on this branch) and we generally aren't OK releasing software that doesn't pass its travis build. We also don't have the time to spend to figure out how to fix it.

If you are going to stick around on RSpec 2.99 (a release that's nearly 2 years old) why do you need to be on rake 11 (which just came out today)?

@JonRowe JonRowe closed this Mar 9, 2016
@JonRowe
Copy link
Member

JonRowe commented Mar 9, 2016

@tricknotes we don't support older releases of RSpec; and as @myronmarston notes this release was intended as an upgrade step to 3.x, if you can't upgrade RSpec for some reason you probably shouldn't upgrade Rake either.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants