Improve and simplify metadata filtering. #2294
Conversation
- Get the value from the metadata hash only once instead of multiple times using `metadata[key]`. - Try `===` method instead of treating regular expressions as special.
|
Nice! |
|
|
||
| meta_value = metadata.fetch(key) { return false } | ||
|
|
||
| return true if TrueClass === filter_value && !!meta_value |
There was a problem hiding this comment.
Why do we !! the meta_value?
There was a problem hiding this comment.
Because TrueClass === '' returns false
There was a problem hiding this comment.
Actually ignore that, why do we !! when it's not being evaluated on it's own and it's not being returned?
There was a problem hiding this comment.
TrueClass === filter_value && !!meta_value here we use !! and to me it looks like a no-op unless the return value of meta_value can be a non-boolean value.
There was a problem hiding this comment.
to me it looks like a no-op unless the return value of meta_value can be a non-boolean value.
It can be a non-boolean value, but thats not an issue if we don't leak it.
There was a problem hiding this comment.
ok so !! converts it to a boolean value, which is either true or false, thanks @JonRowe
…ering Improve and simplify metadata filtering.
multiple times using
metadata[key].===method instead of treating regular expressionsas special.