No need for !! here.

[myronmarston]

Follow up to #2294.

[fables-tales]

Unrelated, but Is there a reason why this isn't filter_value == true?

[myronmarston]

Because filter_value could be anything, and we can't count on it's == being defined properly. We've repeatedly gotten bug reports from users when we've called == on their objects where they defined == to assume the passed object was of the same type, and tried to access specific attributes on it that did not exist. Calling a method on TrueClass instead of filter_value avoids that issue.

It could be true == filter_value but TrueClass === is in keeping with the style of the rest of the method which repeatedly uses SomeClass === value.

[fables-tales]

LGTM, but I did have a question.

[fables-tales]

Right you are, that makes lots of sense. Thanks!

[mrageh]

@myronmarston why do we not need !!, I thought the return type of meta_value was a non-boolean value?

For more context on the original conversation I had with @JonRowe please refer to #2294 (comment)

[JonRowe]

As I was trying to explain over on #2294, it's not needed because we only care if meta_value is truthy.

e.g. if 'string' evaluates to true the same as if !!'string'

!! is typically use to convert a value into a boolean, for example if we were returning the value:

def is_metadata_true?(key)
  !!key
end

def is_metadata_truthy?(key)
  key
end

[mrageh]

Thank you @JonRowe you've clarified it to me now, originally I was confused because I did'nt consider truthy values being eq to true in Ruby.