This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Bump diff-lcs to 1.4.4+ #2833
Merged
Bump diff-lcs to 1.4.4+ #2833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
force-pushed
the
remove-diff-helpers
branch
6 times, most recently
from
4ca1af2 to
fa27056
Compare
4 tasks
pirj
force-pushed
the
remove-diff-helpers
branch
from
fa27056 to
abe2263
Compare
pirj
commented
Dec 29, 2020
| @@ -30,7 +30,7 @@ jobs: | |||
| - 2.3 | |||
| env: | |||
| - | |||
| DIFF_LCS_VERSION: "> 1.4.3" | |||
| BOGUS: "" | |||
There was a problem hiding this comment.
Tried hard to remove the whole this env block to no avail.
There was a problem hiding this comment.
Its the matrix.env call, I don't think theres an if in the syntax 😂 I'd just set it to ruby head false or something
There was a problem hiding this comment.
Right! I've tried:
- removing it
- setting it to an empty array
[] - setting it to an empty hash
{} - leaving a
-
I give up 😆
ruby head false would create a wrong impression that it's there for a good reason, while this non-ambiguously says "some cruft" 😄
There was a problem hiding this comment.
It needs to be either something real, or something explicit, however this also needs back porting to rspec-dev, so it can be addressed later.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…f-helpers Bump diff-lcs to 1.4.4+ --- This commit was imported from rspec/rspec-core@7080ec5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.