Skip to content
This repository was archived by the owner on Nov 30, 2024. It is now read-only.

Stop using DiffHelpers #477

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Stop using DiffHelpers #477

merged 2 commits into from
Dec 30, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Dec 29, 2020

@pirj pirj self-assigned this Dec 29, 2020
@pirj pirj requested review from JonRowe and benoittgt December 29, 2020 17:35
@pirj pirj added this to the 4.0 milestone Dec 29, 2020
@pirj pirj mentioned this pull request Nov 27, 2024
53 tasks
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The differ spec is there to provide specs for the differ, it needs to remain.

@pirj pirj force-pushed the remove-diff-helpers branch from d778460 to fee36d3 Compare December 30, 2020 11:49
@pirj pirj requested a review from JonRowe December 30, 2020 11:50
@pirj pirj force-pushed the remove-diff-helpers branch from fee36d3 to a1aecbc Compare December 30, 2020 11:52
@pirj
Copy link
Member Author

pirj commented Dec 30, 2020

Coverage report generated for RSpec to /home/runner/work/rspec-support/rspec-expectations/coverage. 3116 / 3596 LOC (86.65%) covered.

I don't get it. Locally rspec-expectations's 4-0-dev branch:

 46 files in total.
2793 relevant lines, 2763 lines covered and 30 lines missed. ( 98.93% ) 

@pirj pirj changed the title Remove DiffHelpers Stop using DiffHelpers Dec 30, 2020
@pirj pirj force-pushed the remove-diff-helpers branch from 65398e7 to 002b77b Compare December 30, 2020 12:46
@pirj
Copy link
Member Author

pirj commented Dec 30, 2020

Coverage report generated for RSpec to /home/runner/work/rspec-expectations/rspec-expectations/coverage. 2905 / 3059 LOC (94.97%) covered. according to https://github.com/rspec/rspec-expectations/runs/1626068228?check_suite_focus=true. Same 2330 examples.

pirj added a commit to rspec/rspec-dev that referenced this pull request Dec 30, 2020
@pirj pirj force-pushed the remove-diff-helpers branch from 7afca40 to bb66a69 Compare December 30, 2020 20:30
pirj added a commit to rspec/rspec-dev that referenced this pull request Dec 30, 2020
pirj added a commit to rspec/rspec-dev that referenced this pull request Dec 30, 2020
@JonRowe JonRowe merged commit 56fe9d7 into 4-0-dev Dec 30, 2020
@JonRowe JonRowe deleted the remove-diff-helpers branch December 30, 2020 21:34
JonRowe pushed a commit to rspec/rspec-dev that referenced this pull request Jan 22, 2021
yujinakayama pushed a commit to yujinakayama/rspec-monorepo that referenced this pull request Oct 19, 2021
…e-diff-helpers

Stop using DiffHelpers

---
This commit was imported from rspec/rspec-support@56fe9d7.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants