Fix autoload error

[bquorning]

The specs are currently failing for using Rails 5.0.0.beta2. It looks like the changes from #1388 has something to do with it. I won’t claim to understand all (or anything) of that pull request, but by changing a few pieces, I got the spec suite running and not have only 1 failing spec locally. Let’s see what Travis says.

cc/ @cupakromer

[bquorning]

Note that I included the 1 commit from #1570 which will (hopefully) eventually be merged on its own.

[bquorning]

There you go: a green build. I don’t really understand why my changes make it work.

I noticed that the build error started in the example app’s config/initializers/action_mailer.rb when it references ActionMailer::Base:

NameError: uninitialized constant AbstractController::Rendering
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionpack-5.0.0.beta2/lib/action_controller/base.rb:204:in `<class:Base>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionpack-5.0.0.beta2/lib/action_controller/base.rb:164:in `<module:ActionController>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionpack-5.0.0.beta2/lib/action_controller/base.rb:5:in `<top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/test_case.rb:11:in `<class:TestCase>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/test_case.rb:10:in `<module:ActionView>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/test_case.rb:8:in `<top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/bundler/gems/rails-controller-testing-ce370fe84883/lib/rails-controller-testing.rb:16:in `block in <top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/activesupport-5.0.0.beta2/lib/active_support/lazy_load_hooks.rb:38:in `instance_eval'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/activesupport-5.0.0.beta2/lib/active_support/lazy_load_hooks.rb:38:in `execute_hook'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/activesupport-5.0.0.beta2/lib/active_support/lazy_load_hooks.rb:45:in `block in run_load_hooks'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/activesupport-5.0.0.beta2/lib/active_support/lazy_load_hooks.rb:44:in `each'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/activesupport-5.0.0.beta2/lib/active_support/lazy_load_hooks.rb:44:in `run_load_hooks'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/base.rb:215:in `<class:Base>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/base.rb:139:in `<module:ActionView>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/base.rb:10:in `<top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionview-5.0.0.beta2/lib/action_view/view_paths.rb:1:in `<top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionpack-5.0.0.beta2/lib/abstract_controller/rendering.rb:4:in `<top (required)>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionmailer-5.0.0.beta2/lib/action_mailer/base.rb:426:in `<class:Base>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionmailer-5.0.0.beta2/lib/action_mailer/base.rb:420:in `<module:ActionMailer>'
/home/travis/build/rspec/bundle/ruby/2.2.0/gems/actionmailer-5.0.0.beta2/lib/action_mailer/base.rb:9:in `<top (required)>'
/home/travis/build/rspec/rspec-rails/tmp/example_app/config/initializers/action_mailer.rb:15:in `<top (required)>'

For some reason, there’s a circular dependency! Notice how abstract_controller/rendering.rb:4 is in the trace, and module Rendering isn’t defined until line 16.

[bquorning]

Sigh … specs are failing for Rails master.

[JonRowe]

Kinda expected, to merge this it needs squashing, also shouldn't it be < 5 not 4? 4 builds fine.

[bquorning]

4 builds fine without the hack, so I see no need to include it.

[bquorning]

Squashed.