Bring RSpec current with rails 5 beta 3

[fables-tales]

Biggest issue here is a regression introduced in the rails controller
testing gem which forces us to do a require of
action_controller/metal/rendering in order to not give a NameError
when booting our test app.

[bquorning]

This closes #1571, right?

[bquorning]

Also, I think the require issue just got fixed on Rails master: rails/rails@12cce89

[fables-tales]

@bquorning I worked with @sgrif from rails core on this, so it's likely they've got patches.

[bquorning]

I think, if you rebase on master (after #1571) you’ll have just 1 failing spec.

[fables-tales]

@bquorning I've just pushed a rebased version of this. Let's see what happens.

[bquorning]

Yes, there is now one spec example failing:

Failures:
  1) Action Mailer railtie hook in the development environment respects a custom `preview_path`
     Failure/Error:
       expect(
         capture_exec(
           custom_env.merge('CUSTOM_PREVIEW_PATH' => '/custom/path'),
           exec_script
         )
       ).to eq('/custom/path')

       expected: "/custom/path"
            got: #<struct CaptureExec io="/home/travis/build/rspec/bundle/ruby/2.2.0/gems/rb-inotify-0.9.7/lib/rb-inot...d/rspec/rspec-rails/tmp/example_app/spec/support/default_preview_path:9:in `<main>'", exit_status=0>

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -"/custom/path"
       +"#<struct CaptureExec io=\"/home/travis/build/rspec/bundle/ruby/2.2.0/gems/rb-inotify-0.9.7/lib/rb-inot...d/rspec/rspec-rails/tmp/example_app/spec/support/default_preview_path:9:in `<main>'\", exit_status=0>"

     # ./spec/verify_mailer_preview_path_spec.rb:62:in `block (3 levels) in <top (required)>'

Running specs locally while bisecting the Rails repository, it seems that rails/rails@de6ad56 is the first offending commit. And sure enough, commenting out config.file_watcher = ActiveSupport::EventedFileUpdateChecker from the generated config/environments/development.rb in our example app makes the spec pass.

Maybe just add one line to our example_app_generator/generate_action_mailer_specs.rb?

comment_lines 'config/environments/development.rb', /file_watcher/

Note: I haven’t investigated why that particular line is making the rspec-rails mailer specs fail.

[bquorning]

…or just add a --skip-listen flag in the generate:app and no_active_record:generate:app generators in the Rakefile – see rails/rails@94dbc48

[fables-tales]

@rspec/rspec can I get a review on this?

[JonRowe]

🙄

[fables-tales]

It's totally because rails isn't requiring this properly itself in our sample app, nothing we can really do here :/

[JonRowe]

❤️

[bquorning]

Most of this can/should be reverted once Rails 5.0.0 is out, right?

[fables-tales]

@bquorning we'll assess which parts of it are necessary when the release candidate drops.