Audit tweaks #1799
Merged
Audit tweaks #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is included in all groups automatically.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing an audit of rspec-rails as part of putting together content for the new RSpec book. I ran across a couple things that seemed slightly wrong and/or unnecessary and figured I'd fix them while I'm in there. Check individual commits for explanations of each change.
I don't have a working rspec-rails dev environment (nor do I care to set one up) and I don't really have the time to do any follow up on this, so this can be closed or taken over by another maintainer as desired. I'm mostly opening this so these things don't get forgotten.