Skip to content

Audit tweaks #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rspec/rails/example/feature_example_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def visit(*)
main_feature = nil unless c.expose_dsl_globally?
c.alias_example_group_to :feature, opts
c.alias_example_to :scenario
c.alias_example_to :xscenario
c.alias_example_to :xscenario, :skip => 'Temporarily skipped with xscenario'
end

# Due to load order issues and `config.expose_dsl_globally?` defaulting to
Expand Down
1 change: 0 additions & 1 deletion lib/rspec/rails/example/rails_example_group.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ module RailsExampleGroup
include RSpec::Rails::SetupAndTeardownAdapter
include RSpec::Rails::MinitestLifecycleAdapter if ::Rails::VERSION::STRING >= '4'
include RSpec::Rails::MinitestAssertionAdapter
include RSpec::Rails::Matchers
include RSpec::Rails::FixtureSupport
end
end
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/active_job_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ def to_global_id(options = {})
end

RSpec.describe "ActiveJob matchers", :skip => !RSpec::Rails::FeatureCheck.has_active_job? do
include RSpec::Rails::Matchers

around do |example|
original_logger = ActiveJob::Base.logger
ActiveJob::Base.logger = Logger.new(nil) # Silence messages "[ActiveJob] Enqueued ...".
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_a_new_spec.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
require "spec_helper"

describe "be_a_new matcher" do
include RSpec::Rails::Matchers

context "new record" do
let(:record) do
Class.new do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_new_record_spec.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
require "spec_helper"

describe "be_new_record" do
include RSpec::Rails::Matchers

context "un-persisted record" do
let(:record) { double('record', :persisted? => false) }

Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_valid_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
require 'rspec/rails/matchers/be_valid'

describe "be_valid matcher" do
include RSpec::Rails::Matchers

class Post
include ActiveModel::Validations
attr_accessor :title
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/have_http_status_spec.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
require 'spec_helper'

RSpec.describe "have_http_status" do
include RSpec::Rails::Matchers

def create_response(opts = {})
ActionDispatch::TestResponse.new(opts.fetch(:status)).tap {|x|
x.request = ActionDispatch::Request.new({})
Expand Down