Delay loading system test integration #1903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay loading system tests as late as possible in order to allow people who arent using them to not have to turn off puma or other such things. It also enables other webservers to be configured other than puma which is needed in Rails as of rails/rails@50f6976
|
This seems reasonable, but I don't think I have sufficient context to be the only one to review this. |
|
This looks right to me. 👍 The main thing is making sure Thanks for making this happen, @JonRowe! |
|
👍 |
|
Going to merge this as the build failure is unrelated, will attempt to resolve that when I can |
|
🎉 |
JonRowe
added a commit
that referenced
this pull request
Nov 16, 2017
JonRowe
added a commit
that referenced
this pull request
Nov 20, 2017
Delay loading system tests as late as possible in order to allow people who arent using them to not have to turn off puma or other such things. It also enables other webservers to be configured other than puma which is needed in Rails as of rails/rails@50f6976
JonRowe
added a commit
that referenced
this pull request
Nov 20, 2017
|
This got released as 3.7.2, hopefully helps! |
This was referenced Mar 20, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Delay loading system tests as late as possible in order to allow people who arent using them to not have to turn off puma or other such things. It also enables other webservers to be configured other than puma which is needed in Rails as of rails/rails@50f6976
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay loading system tests as late as possible in order to allow people who arent using them to not have to turn off puma or other such things. It also enables other webservers to be configured other
than puma which is needed in Rails as of rails/rails@50f6976
This should help people who have issues with puma loading when they're not using system test integration. /cc @myronmarston @samphippen @sj26