Ensure that system test screenshots work for specs that have :aggregate_failures enabled #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
screenshot-support-aggregate-failures
branch
from
7e141a9 to
8fe5b58
Compare
|
Would you mind rebasing this off master to check this build passes now master does? |
If RSpec's `:aggregate_failures` is enabled, a system spec with a failed expectation would not automatically trigger a screenshot as expected. This is because aggregated failures are not exposed via the typical `RSpec.current_example.exception`. To correctly detect failures when aggregation is enabled, we have to do more work. This commit works around this problem by using some behind-the-scenes knowledge of how rspec-expectations does the aggregation. Now we reach into the thread-local storage (`RSpec::Support.failure_notifier`) and discover whether there are in fact failures "queued up". If so, we will consider the example to have failed and take a screenshot. This is the same workaround as used by capybara-screenshot: mattheworiordan/capybara-screenshot#213
mattbrictson
force-pushed
the
screenshot-support-aggregate-failures
branch
from
8fe5b58 to
c0c5ae0
Compare
|
Rebased |
|
🎉 |
|
Thanks! |
JonRowe
added a commit
that referenced
this pull request
Nov 16, 2017
JonRowe
added a commit
that referenced
this pull request
Nov 20, 2017
This was referenced Mar 20, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, if RSpec's
:aggregate_failuresis enabled, a system spec with a failed expectation would not automatically trigger a screenshot as expected.This is because aggregated failures are not exposed via the typical
RSpec.current_example.exception. To correctly detect failures when aggregation is enabled, we have to do more work.This PR works around this problem by using some behind-the-scenes knowledge of how rspec-expectations does the aggregation. Now we reach into the thread-local storage (
RSpec::Support.failure_notifier) and discover whether there are in fact failures "queued up". If so, we will consider the example to have failed and take a screenshot.This is the same workaround as used by capybara-screenshot:
mattheworiordan/capybara-screenshot#213