Skip to content

Rake 12.3 cannot install on Ruby 1.9.3. #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

myronmarston
Copy link
Member

No description provided.

@myronmarston
Copy link
Member Author

This issue was exposed by the travis build on rspec/rspec-expectations#1034.

@myronmarston
Copy link
Member Author

Can someone from @rspec/rspec review this? The build failure doesn't seem related, FWIW.

Copy link
Member

@yujinakayama yujinakayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myronmarston
Copy link
Member Author

Thanks, @yujinakayama. @samphippen / @JonRowe how do you feel about this being merged w/ a red build?

@fables-tales
Copy link
Member

@myronmarston I believe this red build is breaking due to the same reason as bundler 1.16.1 on rails:
https://travis-ci.org/rails/rails/builds/319911098
rubygems/bundler#6202
https://travis-ci.org/rails/rails/jobs/319875431

can you try pinning the build to bundler ~> 1.15 and see if it fixes it?

@myronmarston
Copy link
Member Author

can you try pinning the build to bundler ~> 1.15 and see if it fixes it?

How do I do that? I don't remember how and the feedback cycle on pushing changes to the rspec-rails build is sooooo slow.

And actually, rspec/rspec-expectations#1034 is going green now, so this no longer is necessary for what I'm doing there. @samphippen, do you want to take this over? Otherwise I'll probably close it.

@fables-tales
Copy link
Member

@myronmarston I got this :)

@JonRowe
Copy link
Member

JonRowe commented Jan 27, 2018

Closed as rake is upgraded elsewhere!

@JonRowe JonRowe deleted the myron/pin-rake branch January 27, 2018 06:45
@JonRowe JonRowe mentioned this pull request Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants