Skip to content

Pin bundler to fix CI #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Pin bundler to fix CI #1950

merged 1 commit into from
Jan 29, 2018

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Jan 26, 2018

No description provided.

@JonRowe JonRowe force-pushed the fix-ci branch 4 times, most recently from 97451ca to dbb0ec4 Compare January 28, 2018 09:04
@JonRowe JonRowe changed the title [wip] An attempt to fix our CI build Pin bundler to fix CI Jan 28, 2018
@JonRowe
Copy link
Member Author

JonRowe commented Jan 28, 2018

Following on from @samphippen's suggestion in #1935 I hypothesised that if we "down grade" bundler we could fix our build, and it worked, thoughts about merging this and then working on fixing the bundler issue later on? @rspec/rspec?

I got a green build with the version of bundler we use elsewhere, but I've pushed up a commit updating this for rspec-rails to 1.15.x 🤞 that goes green too...

@JonRowe
Copy link
Member Author

JonRowe commented Jan 28, 2018

Woohoo! Green build, can someone review @rspec/rspec ?

@JonRowe
Copy link
Member Author

JonRowe commented Jan 29, 2018

@samphippen @myronmarston can I get a quick review?

Copy link
Member

@myronmarston myronmarston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonRowe JonRowe merged commit 38721b7 into master Jan 29, 2018
@JonRowe JonRowe deleted the fix-ci branch January 29, 2018 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants