[fix-1921] use relative path when no fixture_path configured #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
requested changes
Jan 12, 2018
| if ActionController::TestCase.respond_to?(:fixture_path) | ||
| ActionController::TestCase.fixture_path = value | ||
| end | ||
| ActionController::TestCase.fixture_path = value if ActionController::TestCase.respond_to?(:fixture_path) |
11factory
force-pushed
the
fix-1921
branch
2 times, most recently
from
f82af8a to
e965f58
Compare
|
@JonRowe changes have been done, CI seems already broken before my change |
|
Sadly master is broken thats correct but your branch is more broken than master, so I'd really like to see a green build here! I'm trying to tackle master myself but it might take a while. |
|
I have a green build over in #1950, you could consider rebasing your branch off that to see if your build goes green. |
|
#1950 has now been merged so you should be able to get a green build if you rebase / merge master |
|
ping @JonRowe |
JonRowe
approved these changes
Mar 12, 2018
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #1921