Skip to content

Get rid of redundant requires #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2020
Merged

Get rid of redundant requires #2261

merged 1 commit into from
Jan 12, 2020

Conversation

pirj
Copy link
Member

@pirj pirj commented Jan 11, 2020 •
edited
Loading

We already tell RSpec to require spec/spec_helper.rb in .rspec with --require spec_helper.

@pirj pirj self-assigned this Jan 11, 2020
@pirj pirj force-pushed the get-rid-of-redundant-require branch from 6dbe583 to fd20a53 Compare January 11, 2020 10:36
@pirj pirj marked this pull request as ready for review January 11, 2020 11:09
JonRowe
JonRowe requested changes Jan 12, 2020
View reviewed changes
Copy link
Member

@JonRowe JonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this bar one tweak which is for semantic purposes in the docs.

@JonRowe
Copy link
Member

JonRowe commented Jan 12, 2020

Also I noticed we have several spec files with bare describe top level statements, fancy changing those to RSpec.describe in another PR if you're cleaning things up?

@pirj
Get rid of redundant require
2f3a2c6 
We already tell RSpec to require in `.rspec` with `--require
spec_helper`.
@pirj pirj force-pushed the get-rid-of-redundant-require branch from 0985e31 to 2f3a2c6 Compare January 12, 2020 20:20
@pirj pirj requested a review from JonRowe January 12, 2020 20:20
@pirj
Copy link
Member Author

pirj commented Jan 12, 2020 •
edited
Loading

bare describe top level statements, fancy changing those to RSpec.describe in another PR if you're cleaning things up?

Absolutely 👍 Noticed that as well.

@JonRowe JonRowe merged commit 335afc6 into master Jan 12, 2020
@JonRowe JonRowe deleted the get-rid-of-redundant-require branch January 12, 2020 21:10
JonRowe added a commit that referenced this pull request Jan 12, 2020
@JonRowe
Merge pull request #2261 from rspec/get-rid-of-redundant-require
9aee3b6 
Get rid of redundant requires
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt benoittgt approved these changes

@JonRowe JonRowe Awaiting requested review from JonRowe

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirj @JonRowe @benoittgt