Skip to content

Get rid of redundant requires #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spec/rspec/rails/assertion_adapter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe RSpec::Rails::MinitestAssertionAdapter do
include RSpec::Rails::MinitestAssertionAdapter

Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/assertion_delegator_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe RSpec::Rails::AssertionDelegator do
it "provides a module that delegates assertion methods to an isolated class" do
klass = Class.new {
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/configuration_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require 'rspec/support/spec/in_sub_process'

RSpec.describe "Configuration" do
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/example/channel_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

module RSpec::Rails
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/controller_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

class ::ApplicationController
def self.abstract?; false; end
end
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/feature_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe FeatureExampleGroup do
it_behaves_like "an rspec-rails example group mixin", :feature,
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/helper_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
RSpec.describe HelperExampleGroup do
module ::FoosHelper
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/job_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe JobExampleGroup do
if defined?(ActiveJob)
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/example/mailbox_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

class ApplicationMailbox
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/mailer_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe MailerExampleGroup do
module ::Rails; end
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/model_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe ModelExampleGroup do
it_behaves_like "an rspec-rails example group mixin", :model,
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/request_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe RequestExampleGroup do
it_behaves_like "an rspec-rails example group mixin", :request,
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/routing_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe RoutingExampleGroup do
it_behaves_like "an rspec-rails example group mixin", :routing,
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/example/system_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
module RSpec::Rails
if ActionPack::VERSION::STRING >= "5.1"
RSpec.describe SystemExampleGroup do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/example/view_example_group_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe ViewExampleGroup do
it_behaves_like "an rspec-rails example group mixin", :view,
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/fixture_file_upload_support_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

module RSpec::Rails
describe FixtureFileUploadSupport do
context 'with fixture path set in config' do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/fixture_support_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe FixtureSupport do
context "with use_transactional_fixtures set to false" do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

if RSpec::Rails::FeatureCheck.has_action_cable_testing?
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/action_cable/have_stream_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

if RSpec::Rails::FeatureCheck.has_action_cable_testing?
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/action_mailbox_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

class ApplicationMailbox
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/active_job_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

if RSpec::Rails::FeatureCheck.has_active_job?
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_a_new_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe "be_a_new matcher" do
context "new record" do
let(:record) do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_new_record_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe "be_new_record" do
context "a new record" do
let(:record) { double('record', new_record?: true) }
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/be_routable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe "be_routable" do
include RSpec::Rails::Matchers::RoutingMatchers
attr_reader :routes
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/be_valid_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require 'rspec/rails/matchers/be_valid'

describe "be_valid matcher" do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/has_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

class CollectionOwner < ActiveRecord::Base
connection.execute <<-SQL
CREATE TABLE collection_owners (
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/have_enqueued_mail_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "rspec/rails/feature_check"

if RSpec::Rails::FeatureCheck.has_active_job?
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/have_http_status_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

RSpec.describe "have_http_status" do
def create_response(opts = {})
ActionDispatch::TestResponse.new(opts.fetch(:status)).tap {|x|
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/have_rendered_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

%w[have_rendered render_template].each do |template_expectation|
describe template_expectation do
include RSpec::Rails::Matchers::RenderTemplate
Expand Down
1 change: 0 additions & 1 deletion spec/rspec/rails/matchers/redirect_to_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require "spec_helper"
require "active_support"
require "active_support/test_case"

Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/relation_match_array_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe "ActiveSupport::Relation match_array matcher" do
before { MockableModel.delete_all }

Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/matchers/route_to_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe "route_to" do
include RSpec::Rails::Matchers::RoutingMatchers
include RSpec::Rails::Matchers::RoutingMatchers::RouteHelpers
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/minitest_lifecycle_adapter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

describe RSpec::Rails::MinitestLifecycleAdapter do
it "invokes minitest lifecycle hooks at the appropriate times" do
invocations = []
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/setup_and_teardown_adapter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe RSpec::Rails::SetupAndTeardownAdapter do
describe "::setup" do
it "registers before hooks in the order setup is received" do
Expand Down
2 changes: 0 additions & 2 deletions spec/rspec/rails/view_rendering_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "spec_helper"

module RSpec::Rails
describe ViewRendering do
let(:group) do
Expand Down
1 change: 0 additions & 1 deletion spec/sanity_check_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'spec_helper'
require 'pathname'

RSpec.describe "Verify required rspec dependencies" do
Expand Down