Streamline RSpec config

[pirj]

Disable monkey patching and fix specs related to this.

[pirj]

@JonRowe please take another look. Enabled partial double verification.

[pirj]

No idea why it was passing before.

[JonRowe]

Is view not also a method?

[pirj]

Doesn't seem so, at least not it the bare context of ExampleGroup.describe.
This is needed here.
Picked it up here.
I suspect that with_isolated_config was swallowing NoMethodError previously.

[JonRowe]

Nope nor these links

[JonRowe]

with_isolated_config does not swallow errors, it just runs an ensure

[JonRowe]

It's defined here: lib/rspec/rails/example/view_example_group.rb:81 so this should be removed...

[pirj]

I see your point.

When I comment out with_isolated_config and locally defined view double, the hook is not executed. It is not executed with with_isolated_config or if metadata condition is removed.

The following doesn't work either:

      context 'with a hook' do
        let(:run_count) { [] }

        before(:each, :type => :view) do
          allow(view).to receive(:a_stubbed_helper) { :value }
          run_count << 1
        end

        it 'is accessible to hooks' do
          group = RSpec::Core::ExampleGroup.describe 'a view', :type => :view do
            specify { true }
          end
          group.run NullObject.new
          expect(run_count.first).to eq 1
        end
      end

Any suggestions?

[JonRowe]

You need to keep with_isolated_config, if your changes here are causing an error you need to ensure the right methods are defined, doing double here is just wrong..

[pirj]

A call to allow(view).to receive(:a_stubbed_helper) { :value } results in:

RSpec::Mocks::MockExpectationError: #<#<Class:0x00007fa59165da18>:0x00007fa59165ceb0 @_config={}, ...> does not implement: a_stubbed_helper

that for some reason doesn't bubble up.
The same happens if you move stubbing directly to the example:

          group = RSpec::Core::ExampleGroup.describe 'a view', :type => :view do
            specify {
              allow(view).to receive(:a_stubbed_helper) { :value }
              run_count += 1
            }
          end

Example returns prematurely, run_count is not incremented, but there's no exception from mocks. Is it a bug?

Changed to stub an existing render method instead.

Removed NullObject.new from group.run's arguments, it doesn't seem to affect this in any way.

[JonRowe]

Looking good, a few questions mostly out of curiosity.

[JonRowe]

Is view not also a method?

[JonRowe]

It's defined here: lib/rspec/rails/example/view_example_group.rb:81 so this should be removed...

[pirj]

I see your point.

When I comment out with_isolated_config and locally defined view double, the hook is not executed. It is not executed with with_isolated_config or if metadata condition is removed.

The following doesn't work either:

      context 'with a hook' do
        let(:run_count) { [] }

        before(:each, :type => :view) do
          allow(view).to receive(:a_stubbed_helper) { :value }
          run_count << 1
        end

        it 'is accessible to hooks' do
          group = RSpec::Core::ExampleGroup.describe 'a view', :type => :view do
            specify { true }
          end
          group.run NullObject.new
          expect(run_count.first).to eq 1
        end
      end

Any suggestions?

[JonRowe]

Apart from figuring out the double issue this looks almost good to go, I think theres a bad rebase gone on though...

[pirj]

Rebase fixed, all green.

[JonRowe]

Looking really good but I spotted one last thing!

[JonRowe]

Doesn't this cause the groups output to be output to the real formatter?

[pirj]

There's no difference in the output.

[JonRowe]

I was surprised by that assertion, as the point of this object is to prevent the real reporter being used, but its failing locally for me? I want to investigate this further as its not possible to prove either way on CI without changing the format...

What I expect this to do is to add the spec you've specified above into the reporter, so if you run this spec on its own you'd see "2 examples passed" for this one example.

[pirj]

If I run it focused (rspec spec/rspec/rails/example/view_example_group_spec.rb:236), it fails locally. However, the spec when run altogether passes.
This weird behavior remains even with just one example left, and if you remove module namespace, and with_isolated_, and nesting contexts. I've put it on my list to investigate.

[pirj]

Maybe it doesn't add to the main reporter because of https://github.com/rspec/rspec-rails/pull/2264/files#diff-93830fa29d616f7c87903d08b5b1b29aR55 ?

  config.around(:example) do |example|
    real_world = RSpec.world
    RSpec.instance_variable_set(:@world, RSpec::Core::World.new)
    example.run
    RSpec.instance_variable_set(:@world, real_world)
  end

[pirj]

I'm not sure if with_isolated_config is even necessary in specs with that hook.

[JonRowe]

So I got to the bottom of why this doesn't run when focused. If you're interested its an artefact in our filtering, with_isolated_config does not remove filters from this spec, as they exist in the world and the world is not isolated. That is something I might consider fixing at some point but is waaaaaaaaay out of scope for this.

I also confirmed this removal is ok, we now use a NullReporter by default, a change which post-dates this spec I suspect.

[benoittgt]

Thanks!

[JonRowe]

So I got to the bottom of why this doesn't run when focused. If you're interested its an artefact in our filtering, with_isolated_config does not remove filters from this spec, as they exist in the world and the world is not isolated. That is something I might consider fixing at some point but is waaaaaaaaay out of scope for this.

I also confirmed this removal is ok, we now use a NullReporter by default, a change which post-dates this spec I suspect.