Fix Rubocop offences

[babrovka]

No description provided.

[JonRowe]

👋 Thanks for taking the time to contribute this, in order for this to make sense as a PR the rubocop check within out build needs to be changed to apply to the entire project. Currently we only apply the rules to lib so if you'd like this merged it will need to be expanded to the whole project. Its in script/functions.sh

[babrovka]

👋 Thanks for taking the time to contribute this, in order for this to make sense as a PR the rubocop check within out build needs to be changed to apply to the entire project. Currently we only apply the rules to lib so if you'd like this merged it will need to be expanded to the whole project. Its in script/functions.sh

hey @JonRowe 👋 glad to help! I updated script/functions.sh so now Rubocop will check the whole project.

Please, don't merge it right now, I would like to go through all cops, one per commit.

[pirj]

Oh wow, it took me a while to look though it.

Do you mind fixing a couple more things along the way?

• mentions of rubocop lib in BUILD_DETAILS.md and DEVELOPMENT.md
• https://github.com/bbatsov/rubocop => https://github.com/rubocop-hq/rubocop in BUILD_DETAILS.md
• (minor, optional) in script/after_update_travis_build.sh we remove .rubocop_rspec_base.yml which doesn't exist in this repo, is it needed?

I'm a bit concerned about disabling RedundantSelf, Colon, and weird new octal notation.

The rest of the comments are minor, I enjoy the new style, and would be happy to merge as-is.

Good job! 👏

Just an idea for a follow-up: we have some disabled cops in .rubocop_todo.yml, some of them are due to Ruby 1.8 legacy, and it should be quite easy to fix them.

[pirj]

Updated from master and push-forced.

I can reproduce this locally:

spec/rspec/rails/example/feature_example_group_spec.rb:24:23: C: Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
          get "/foo", :as => :foo, :to => "foo#bar"
                      ^^^^^^

fixed ✅

Regarding:

        group = RSpec::Core::ExampleGroup.describe do
          include RequestExampleGroup
        end.describe do
          include FeatureExampleGroup
        end

and

spec/rspec/rails/example/feature_example_group_spec.rb:29:9: C: Style/MultilineBlockChain: Avoid multi-line chains of blocks.
        end.describe do
        ^^^^^^^^^^^^

wondering if this can be written as:

        group = RSpec::Core::ExampleGroup.describe do
          include RequestExampleGroup
          describe do
            include FeatureExampleGroup
          end
        end

will group be the outer group or the inner one?
Might be:

        outer_group = RSpec::Core::ExampleGroup.describe do
          include RequestExampleGroup
        end
        group = outer_group.describe do
          include FeatureExampleGroup
        end

[pirj]

Checked, group has the same ancestors as originally when the second approach is used.

[pirj]

Looks green 👍
@babrovka do you mind checking the remaining notes #2272 (review) ?

[JonRowe]

I'm happy with this if it is done @babrovka? please let me handle the merge @pirj

[pirj]

Layout/SpaceInsideBlockBraces:
EnforcedStyleForEmptyBraces: space
19 offences

Layout/SpaceInsideBlockBraces:
EnforcedStyleForEmptyBraces: no_space (default)
51 offences

Reworked to use non-default space style for empty blocks.

[pirj]

Great job, @babrovka !

I'm ok with this, looks perfect. Good to squash-merge, @JonRowe?

[JonRowe]

Just one thing to change @pirj

[JonRowe]

Thanks for your work here @babrovka and @pirj